This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Fix: use lolex only for setTimeout function to avoid mongodb to stall #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeviaVir
approved these changes
Oct 9, 2020
xwolfyxNL
added a commit
to xwolfyxNL/zenbot
that referenced
this pull request
Jan 5, 2021
Reverts commit DeviaVir#2425 and fixes the broken sim results
Merged
DeviaVir
pushed a commit
that referenced
this pull request
Jan 6, 2021
Reverts commit #2425 and fixes the broken sim results
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically since version 3.6.2 mongodb library has replaced processWaitQueue with setImmediate.
lolex.install() is monkey patching setImmediate which is causing mongodb library to stall.
Here you can see more details about this:
mongodb/node-mongodb-native#2537
Automattic/mongoose#9417
So, in order to solve the problem we will only use lolex for setTimeout and not for other clock methods.
It fixes: #2412 (comment)