This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Add kraken extension #214
Merged
Add kraken extension #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some variables were incorrect
Fixing some misplaced variables
Added default config options, fix trade and error reporting
- Retry now only on ETIMEDOUT
getOrder working, and properly(?) handling retries now
More error handling for recoverable/reconnect errors and trade
Adjusted minimum order size according to https://support.kraken.com/hc/en-us/articles/205893708-What-is-the-minimum-order-size-
Merge branch 'feat/kraken' of https://github.com/Alexandre-io/zenbot into feat/kraken Conflicts: extensions/kraken/exchange.js
…ed Kraken to README and removed ; at end of lines
Closed
supersabbath
pushed a commit
to supersabbath/zenbot
that referenced
this pull request
Oct 2, 2017
* Add kraken support * Fixing some misplaced variables Some variables were incorrect * fix trade time * better error handling * Fix getOrder && trade * Added default config options, fix trade and error reporting * Remove debug * Remove retries * - getOrders now working & reporting closed orders properly - Retry now only on ETIMEDOUT * More error handling for recoverable/reconnect errors and trade * Fix errors matching * Fix retry * More verbose retries (we need to eliminate them! ;)) Adjusted minimum order size according to https://support.kraken.com/hc/en-us/articles/205893708-What-is-the-minimum-order-size- * Adjust to an earlier upstream change * Longer retries when hitting API rate limit and retry() also for getTrades * Borrowed order caching from extensions/poloniex/ * It's min_size: 0.01 and not min_total... * update-products.sh for min_size * Added logic for post only orders (handled differently by Kraken), added Kraken to README and removed ; at end of lines * Removed more ; All credits go to @Alexandre-io, @crubb, @nibzo1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the kraken extension for zenbot 4
All credits go to @Alexandre-io, @crubb, @nibzo1 (#207)
close #177 #196
re-creating from
crubb/zenbot:featso we can pull this one ahead