This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Add check to end simulation and add drain function properly #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olexiyb
pushed a commit
to olexiyb/zenbot
that referenced
this pull request
Feb 2, 2020
YarnSeemannsgarn
pushed a commit
to YarnSeemannsgarn/zenbot
that referenced
this pull request
Apr 15, 2020
This was referenced Oct 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulation ends unexpectedly without generating the final report and html file.
This is because onCollectionCursorEnd() should be called in order to generate the final report. Checking when the amount of trades from mongoDb is zero, you can call that function to get the report. I have created an issue #1976.