This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Fix Darwin backfill oversight #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I evaluated the wrong increment. Backfilling should only happen at the start of the run. In the future this needs to be made a parameter. Backfilling only once insures consistent evaluations without introducing new data on each generation But I can see a use where use case where updating data would help it to evolve as new data is collected.
DeviaVir
approved these changes
Feb 5, 2018
This was referenced Mar 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I evaluated the wrong increment.
Backfilling should only happen at the start of the run.
In the future this needs to be made a parameter.
Backfilling only once insures consistent evaluations without
introducing new data on each generation
But I can see a use case where updating data would help it to
evolve as new data is collected.