Some gradle performance and user experience improvements #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working with the LIO-SDK in the past couple of days, and through the process, I've found that these little improvements could help those who come to use it after me.
Improve gradle performance: Since the project is using gradle 3+, this should speed up a lot the gradle build. More info: https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_separation
Added permission request for location access and camera access: For those using normal android devices, not the real LIO, with the emulator, like me in the beginning, this should help a little.
Added a "debug only" toast message to instruct about the Map Box's access token.