This repository has been archived by the owner on Mar 15, 2022. It is now read-only.
Refactor: Remove duplicated code in custom-server.js #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
dag-andersen
reviewed
May 2, 2020
Comment on lines
+119
to
+130
| - name: Rolling updates | ||
| uses: appleboy/ssh-action@master | ||
| with: | ||
| host: 167.172.180.155 # Leader IP | ||
| USERNAME: root | ||
| KEY: ${{ secrets.CI_swarm_private_key }} | ||
| script: | | ||
| echo ${{ secrets.db-config }} >> db-config | ||
| source db-config | ||
| docker stack up minitwit -c minitwit_stack.yml | ||
| docker service update -d --image dagandersen/frontend:latest minitwit_fontend | ||
|
|
There was a problem hiding this comment.
Tænker ikke det giver så meget mening at merge det her - eftersom at clusteret er nede, og dette vil breake pipelinen
Så giver det mere mening at beholde den nede på linje 146/158, som den allerede er på
There was a problem hiding this comment.
OBS: på dette PR står rolling-updates steppet 2 gange i pipelinen
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.