Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put cicd db password in a secret #155

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,4 @@ jobs:
TARGET: production
SESSION_SECRET: ${{ secrets.SESSION_SECRET }}
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
CICD_DB_PASSWORD: ${{ secrets.CICD_DB_PASSWORD }}
6 changes: 3 additions & 3 deletions tests_compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ services:
image: postgres:latest
environment:
POSTGRES_USER: postgres
POSTGRES_PASSWORD: postgres
POSTGRES_PASSWORD: ${CICD_DB_PASSWORD}
POSTGRES_DB: testdb
PGPORT: 9999
ports:
Expand All @@ -27,7 +27,7 @@ services:
- test_db
environment:
- HUSKY=0
- DATABASE_URL=postgresql://postgres:postgres@test_db:9999/testdb
- DATABASE_URL=postgresql://postgres:${CICD_DB_PASSWORD}@test_db:9999/testdb
- SESSION_SECRET=secret
restart: always

Expand All @@ -45,7 +45,7 @@ services:
- test_db
environment:
- HUSKY=0
- DATABASE_URL=postgresql://postgres:postgres@test_db:9999/testdb
- DATABASE_URL=postgresql://postgres:${CICD_DB_PASSWORD}@test_db:9999/testdb
- SESSION_SECRET=secret
restart: always

Expand Down
Loading