-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix error message for :userProfile
#7972
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titerman
reviewed
Aug 24, 2023
src/errors/runtime/templates.js
Outdated
@@ -154,5 +154,5 @@ export default { | |||
[RUNTIME_ERRORS.cannotImportESMInCommonsJS]: 'Cannot import the {esModule} ECMAScript module from {targetFile}. Use a dynamic import() statement or enable the --esm CLI flag.', | |||
[RUNTIME_ERRORS.setNativeAutomationForUnsupportedBrowsers]: 'The "{browser}" do not support the Native Automation mode. Use the "disable native automation" option to continue.', | |||
[RUNTIME_ERRORS.cannotRunLegacyTestsInNativeAutomationMode]: 'TestCafe cannot run legacy tests in Native Automation mode. Disable native automation to continue.', | |||
[RUNTIME_ERRORS.setUserProfileInNativeAutomation]: 'The "userProfile" option is enabled for the following browsers: "{browsers}".\nThe "userProfile" option is not supported in the Native Automation mode.\nUse the "disable native automation" option or remove "userProfile" option to continue.', | |||
[RUNTIME_ERRORS.setUserProfileInNativeAutomation]: 'When TestCafe uses native automation, it cannot apply the "userProfile" option. To continue, disable native automation, or remove the "userProfile" suffix for the following browsers: "{browsers}".', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
[RUNTIME_ERRORS.setUserProfileInNativeAutomation]: 'When TestCafe uses native automation, it cannot apply the "userProfile" option. To continue, disable native automation, or remove the "userProfile" suffix for the following browsers: "{browsers}".', | |
[RUNTIME_ERRORS.setUserProfileInNativeAutomation]: 'Cannot initialize the test run.\nWhen TestCafe uses native automation, it can only launch browsers with an empty user profile.\nDisable native automation, or remove the "userProfile" suffix from the following\nbrowser aliases: "{browsers}".', |
Co-authored-by: titerman <[email protected]>
Aleksey28
approved these changes
Aug 25, 2023
Release v3.3.0-rc.2 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
already checked by @titerman