add run context to reportItem #2703 #2720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit cc8c95b have failed. See details: |
|
❌ Tests for the commit f50846c have failed. See details: |
|
@testcafe-build-bot /retest |
miherlosev
requested changes
Aug 14, 2018
| @@ -31,7 +31,8 @@ export default class Reporter { | |||
| errs: [], | |||
| unstable: false, | |||
| startTime: null, | |||
| testRunInfo: null | |||
| testRunInfo: null, | |||
| contexts: [] | |||
There was a problem hiding this comment.
There are two different contexts: fixture and test.
See this help topic for more detail.
So instead of a single context prop, please add two properties: ctx and fixtureCtx.
| @@ -43,7 +44,8 @@ export default class Reporter { | |||
| screenshotPath: reportItem.screenshotPath, | |||
| screenshots: reportItem.screenshots, | |||
| quarantine: reportItem.quarantine, | |||
| skipped: reportItem.test.skip | |||
| skipped: reportItem.test.skip, | |||
| contexts: sortBy(reportItem.contexts, 'userAgent') | |||
There was a problem hiding this comment.
I guess sorting is not necessary.
In general case, a custom reporter plugin should decide itself will it sort contexts or not.
|
Thank you for your work. At present, we have some problems with running our tests in mobile browsers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.