Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added returnDOMNodes option in addCustomMethods(closes #1919) #2173

Merged
merged 7 commits into from
Mar 7, 2018
Merged

Added returnDOMNodes option in addCustomMethods(closes #1919) #2173

merged 7 commits into from
Mar 7, 2018

Conversation

kirovboris
Copy link
Collaborator

No description provided.

@kirovboris kirovboris changed the title [WIP] Added Selector mode in adCustomMethods(closes #1919) [WIP] Added Selector mode in addCustomMethods(closes #1919) Feb 26, 2018
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 49ee5d9 have failed. See details:

@kirovboris
Copy link
Collaborator Author

@testcafe-build-bot \retest

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit d1a4d2f have failed. See details:

@kirovboris
Copy link
Collaborator Author

@testcafe-build-bot \retest

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit d1a4d2f have failed. See details:

@kirovboris
Copy link
Collaborator Author

@testcafe-build-bot \retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit d1a4d2f have passed. See details:

@kirovboris kirovboris changed the title [WIP] Added Selector mode in addCustomMethods(closes #1919) Added Selector mode in addCustomMethods(closes #1919) Mar 5, 2018
@kirovboris
Copy link
Collaborator Author

/cc @helen-dikareva @AndreyBelym

@kirovboris kirovboris changed the title Added Selector mode in addCustomMethods(closes #1919) Added addAsSelector option in addCustomMethods(closes #1919) Mar 5, 2018
@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit accc2bb have passed. See details:

helen-dikareva
helen-dikareva reviewed Mar 6, 2018
View reviewed changes
test/functional/fixtures/api/es-next/selector/test.js Outdated
var DEFAULT_SELECTOR_TIMEOUT = 3000;
var DEFAULT_RUN_OPTIONS = { selectorTimeout: DEFAULT_SELECTOR_TIMEOUT };
var DEFAULT_SELECTOR_TIMEOUT = 3000;
var DEFAULT_RUN_OPTIONS = { selectorTimeout: DEFAULT_SELECTOR_TIMEOUT };
var DEFAULT_CHROME_RUN_OPTIONS = { only: 'chrome', selectorTimeout: 3000 };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use here DEFAULT_SELECTOR_TIMEOUT too

@kirovboris kirovboris mentioned this pull request Mar 6, 2018
Merged
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit d3176a9 have failed. See details:

@kirovboris
Copy link
Collaborator Author

@testcafe-build-bot \retest

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit d3176a9 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit d770baf have failed. See details:

@kirovboris
Copy link
Collaborator Author

@testcafe-build-bot \retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit d770baf have passed. See details:

@kirovboris
Copy link
Collaborator Author

/cc @AndreyBelym

@kirovboris
Copy link
Collaborator Author

FPR

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 8945418 have passed. See details:

@AndreyBelym AndreyBelym changed the title Added addAsSelector option in addCustomMethods(closes #1919) Added returnDOMNodes option in addCustomMethods(closes #1919) Mar 7, 2018
@AndreyBelym
Copy link
Contributor

Option named checked with @VasilyStrelyaev

@AndreyBelym AndreyBelym merged commit ed834dd into DevExpress:master Mar 7, 2018
@smockle smockle mentioned this pull request Apr 20, 2018
Merged
kirovboris pushed a commit that referenced this pull request Apr 23, 2018
@smockle @kirovboris
Add types for second parameter, added in #2173 (#2335)
fa9e412
kirovboris added a commit to kirovboris/testcafe-phoenix that referenced this pull request Dec 18, 2019
@kirovboris
Added returnDOMNodes option in addCustomMethods(closes DevExpress#1919)…
5c8731a 
… (DevExpress#2173)
kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this pull request Dec 18, 2019
@smockle @kirovboris
Add types for second parameter, added in DevExpress#2173 (DevExpress#…
d290c24 
…2335)
@snyk-bot snyk-bot mentioned this pull request Aug 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helen-dikareva helen-dikareva helen-dikareva approved these changes

@AndreyBelym AndreyBelym AndreyBelym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirovboris @testcafe-build-bot @AndreyBelym @helen-dikareva