Hammerhead overrides some attributes, that are used in non-standard way, with null

[intermike]

Are you requesting a feature or reporting a bug?

Bug

What is the current behavior?

Hammerhead nullifies attributes, that are used in non-standard way, e.g. @action for <input>.

What is the expected behavior?

Hammerhead leaves attributes, that are used in non-standard way, as they are.

How would you reproduce the current behavior (if this is a bug)?

The JS code on tested page

var div = document.createElement('div');
div.innerHTML = '<input type="submit" action="#test-me-out">';
console.log(div.firstChild.outerHTML);

produces this console output:

> <input type="submit" action="null">

But the code should produce the following:

> <input type="submit" action="#test-me-out">

Provide the test code and the tested page URL (if applicable)

Add the following test in testcafe-hammerhead/test/client/fixtures/sandbox/code-instrumentation/getters-test.js and observe it fails:

test('leaving attributes, that are used in non-standard way, as they are', function () {
    var htmlText = '<input action="#test-me-out">';
    var div      = document.createElement('div');

    setProperty(div, 'innerHTML', htmlText);

    var a = div.firstChild;

    strictEqual(a.outerHTML, processHtml(htmlText));
    strictEqual(getProperty(a, 'outerHTML'), htmlText);
});

Specify your

• operating system: MacOS, Windows
• testcafe version: 0.19.2
• node.js version: 9.8.0

[intermike]

I have the fix already and I'm willing to create a pull request.

[intermike]

DevExpress/testcafe-hammerhead#1583

[lock]

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.