fix Shouldn't process shadow ui elements (close #1570)
#1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit a0436bc have failed. See details: |
|
❌ Tests for the commit bcebd87 have failed. See details: |
|
@testcafe-build-bot \retest |
|
✅ Tests for the commit bcebd87 have passed. See details: |
miherlosev
suggested changes
Apr 16, 2018
src/client/sandbox/node/index.js
Outdated
| @@ -46,7 +46,7 @@ export default class NodeSandbox extends SandboxBase { | |||
| _processElement (el) { | |||
| const processedContext = el[INTERNAL_PROPS.processedContext]; | |||
|
|
|||
| if (processedContext !== this.window) { | |||
| if (!domUtils.isShadowUIElement(el) && processedContext !== this.window) { | |||
There was a problem hiding this comment.
minor enhancement: let's use a fast forward paradigm and remove one level of the brackets
...
...
if (domUtils.isShadowUIElement(el) || processedContext === this.window)
retrun;
...| test('should not process shadow ui elements (GH-1570)', function () { | ||
| var shadowUIElements = hammerhead.nativeMethods.querySelectorAll.call(document, '[class$="-hammerhead-shadow-ui"]'); | ||
|
|
||
| for (var i = 0; i < shadowUIElements.length; i++) |
There was a problem hiding this comment.
Also before the loop, add a check that garanties there are shadow ui elements.
ok(shadowUIElements.length);
|
❌ Tests for the commit cabb1fc have failed. See details: |
|
@testcafe-build-bot \retest |
|
✅ Tests for the commit cabb1fc have passed. See details: |
|
FPR |
miherlosev
approved these changes
Apr 17, 2018
AndreyBelym
pushed a commit
to AndreyBelym/testcafe-hammerhead
that referenced
this pull request
Feb 28, 2019
…evExpress#1571) * fix `Shouldn't process shadow ui elements` (close DevExpress#1570) * fix review issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.