DateBox: fix formatting of min/max attribute in datetime picker type (T1252602) #28647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-shakhova
requested changes
Dec 27, 2024
packages/devextreme/js/__internal/ui/date_box/m_date_box.strategy.native.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/datebox.tests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/datebox.tests.js
Outdated
Show resolved
Hide resolved
…25_1-fix-min/max-format-in-datetime-picker
packages/devextreme/js/__internal/ui/date_box/m_date_box.strategy.native.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/datebox.tests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/datebox.tests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/date_box/m_date_box.strategy.native.ts
Show resolved
Hide resolved
…25_1-fix-min/max-format-in-datetime-picker
anna-shakhova
approved these changes
Jan 7, 2025
| assert.equal($input.attr('min'), '12:00:14', 'minimum time set correctly'); | ||
| assert.equal($input.attr('max'), '18:00:15', 'maximum time set correctly'); | ||
| }); | ||
| QUnit.test('Datebox should set min/max attributes to date input in localized date format (T1252602)', function(assert) { |
There was a problem hiding this comment.
[minor] line break is missing. Let's take it into account in your future PRs and cherry-picks
EugeniyKiyashko
approved these changes
Jan 7, 2025
nikkithelegendarypokemonster
merged commit 78795c0
into
DevExpress:25_1
284 checks passed
nikkithelegendarypokemonster
added a commit
to nikkithelegendarypokemonster/DevExtreme
that referenced
this pull request
Jan 8, 2025
…(T1252602) (DevExpress#28647) # Conflicts: # packages/devextreme/js/__internal/ui/date_box/m_date_box.strategy.native.ts
nikkithelegendarypokemonster
added a commit
to nikkithelegendarypokemonster/DevExtreme
that referenced
this pull request
Jan 8, 2025
…er type (T1252602) (DevExpress#28647)" This reverts commit 7140e62.
nikkithelegendarypokemonster
added a commit
to nikkithelegendarypokemonster/DevExtreme
that referenced
this pull request
Jan 8, 2025
nikkithelegendarypokemonster
added a commit
to nikkithelegendarypokemonster/DevExtreme
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.