Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: setup new EdgeWorker SDK with cloud and local bucketing #566

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

feat: setup new EdgeWorker SDK with cloud and local bucketing #566

wants to merge 15 commits into from

Conversation

jonathannorris
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Sep 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-sdks-next-js ❌ Failed (Inspect) Oct 24, 2023 8:05pm
js-sdks-web-elements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 8:05pm
js-sdks-with-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 8:05pm

This was referenced Sep 27, 2023
Merged
Merged
Merged
Merged
@jonathannorris Graphite App
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@jonathannorris jonathannorris force-pushed the DVC-9059-edge-worker-sdk branch from b17a73e to 20f66d9 Compare September 29, 2023 18:26
@jonathannorris jonathannorris force-pushed the DVC-9059-edge-worker-sdk branch 2 times, most recently from cd30000 to 16d5c3b Compare October 2, 2023 19:34
jonathannorris
jonathannorris commented Oct 2, 2023
View reviewed changes
lib/shared/server-request/src/request.ts
export const EVENT_URL = 'https://events'
export const EVENTS_PATH = '/v1/events/batch'

export async function publishEvents(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moving common event publishing route to the shared lib.

jonathannorris
jonathannorris commented Oct 2, 2023
View reviewed changes
sdk/js-cloud-server/src/types.ts
@@ -135,33 +135,6 @@ export interface DVCVariableInterface {
readonly evalReason?: unknown
}

export interface DevCycleEvent {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to request lib where it is used

jonathannorris
jonathannorris commented Oct 2, 2023
View reviewed changes
sdk/nodejs/src/eventQueue.ts
import { publishEvents } from './request'
import { DevCycleEvent, DVCPopulatedUser } from '@devcycle/js-cloud-server-sdk'

export const AggregateEventTypes: Record<string, string> = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to common place in request lib.

jonathannorris
jonathannorris commented Oct 2, 2023
View reviewed changes
sdk/nodejs/src/request.ts
export const EVENT_URL = 'https://events'
export const EVENTS_PATH = '/v1/events/batch'

export async function publishEvents(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to request lib

@jonathannorris jonathannorris force-pushed the DVC-9059-edge-worker-sdk branch from e64838d to 0bcc9be Compare October 24, 2023 17:51
@vercel vercel bot temporarily deployed to Preview – js-sdks-web-elements October 24, 2023 18:06 Inactive
@jonathannorris jonathannorris force-pushed the DVC-9059-edge-worker-sdk branch from 0bcc9be to d0a96cc Compare October 24, 2023 19:12
@jonathannorris jonathannorris force-pushed the DVC-9059-edge-worker-sdk branch from d0a96cc to ecd39f0 Compare October 24, 2023 19:56
Base automatically changed from DVC-9059-request-lib to main October 24, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonathannorris