feat: update sdk to support sdkPlatform metadata, update WASM lib, update OpenFeature #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonathannorris
commented
Feb 12, 2025
•
jonathannorris
commented
- Update SDK to support setting sdkPlatform metadata for OpenFeature providers.
- Update to latest OpenFeature spec
- Add event tracking support in OpenFeature provider
- Use new initialization format for OpenFeature
Signed-off-by: Jonathan Norris <[email protected]>
JamieSinn
approved these changes
Feb 12, 2025
jonathannorris
commented
Feb 12, 2025
src/test/java/com/devcycle/sdk/server/common/model/DevCycleUserTest.java
Outdated
Show resolved
Hide resolved
jonathannorris
commented
Feb 12, 2025
src/main/java/com/devcycle/sdk/server/local/api/DevCycleLocalClient.java
Outdated
Show resolved
Hide resolved
jonathannorris
commented
Feb 12, 2025
src/main/java/com/devcycle/sdk/server/openfeature/DevCycleProvider.java
Outdated
Show resolved
Hide resolved
jonathannorris
commented
Feb 12, 2025
| throw new GeneralError("DevCycle client not initialized within 2 seconds"); | ||
| } | ||
| Thread.sleep(5); | ||
| } while (!devcycleClient.isInitialized()); |
There was a problem hiding this comment.
this is how it's done in Flagd provider and other places...
There was a problem hiding this comment.
don't we have a way of doing our initialization callback here? That would be cleaner
There was a problem hiding this comment.
well, no, this function is also synchronous and wouldn't do anything with a callback here. https://openfeature.dev/docs/reference/technologies/server/java#synchronous
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.