DVC-6731 set json config data with utf8 byte arrays #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-hoefgen
force-pushed
the
DVC-6731-set-config-utf8
branch
from
39e6a41 to
36f1a8b
Compare
chris-hoefgen
force-pushed
the
DVC-6731-set-config-utf8
branch
from
ab9eabc to
310b572
Compare
ajwootto
reviewed
Mar 28, 2023
ajwootto
reviewed
Mar 28, 2023
ajwootto
reviewed
Mar 28, 2023
ajwootto
approved these changes
Mar 28, 2023
chris-hoefgen
force-pushed
the
DVC-6731-set-config-utf8
branch
from
96a38e0 to
43d5d40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the setConfigData(), setPlatformData(), setClientCustomData() to use the new Uint8Array versions in AssemblyScript to send proper utf-8 encoded string data into the WASM.
Adds a new assemblyScript util function to set Uint8Arrays outside of memory pools
New unit test and unit test data file that contains special characters to test encoding