chore: update LD importer to use v2 endpoints #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elliotCamblor
commented
Oct 1, 2024
•
elliotCamblor
commented
- Update to use v2 endpoints. These consolidate the feature configuration and feature updating into one endpoint.
- Update to support new startWith/endWith comparators. These map to LD startsWith/endsWith.
- Tested manually here: https://app.devcycle.com/o/org_U9F8YMaTChTEndWw/p/elliot-importer-test/features
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -140,7 +141,7 @@ | |||
|
|
|||
| async createFeature(projectKey: string, feature: Feature): Promise<Feature> { | |||
| const headers = await this.getHeaders() | |||
| const response = await fetch(`${DVC_BASE_URL}/projects/${projectKey}/features`, { | |||
| const response = await fetch(`${DVC_BASE_URL_V2}/projects/${projectKey}/features`, { | |||
Check warning
Code scanning / CodeQL
File data in outbound network request Medium
| @@ -151,7 +152,7 @@ | |||
|
|
|||
| async updateFeature(projectKey: string, feature: Feature): Promise<Feature> { | |||
| const headers = await this.getHeaders() | |||
| const response = await fetch(`${DVC_BASE_URL}/projects/${projectKey}/features/${feature.key}`, { | |||
| const response = await fetch(`${DVC_BASE_URL_V2}/projects/${projectKey}/features/${feature.key}`, { | |||
Check warning
Code scanning / CodeQL
File data in outbound network request Medium
| @@ -162,7 +163,7 @@ | |||
|
|
|||
| async getFeaturesForProject(projectKey: string): Promise<Feature[]> { | |||
| const headers = await this.getHeaders() | |||
| const response = await fetch(`${DVC_BASE_URL}/projects/${projectKey}/features?perPage=1000`, { | |||
| const response = await fetch(`${DVC_BASE_URL_V2}/projects/${projectKey}/features?perPage=1000`, { | |||
Check warning
Code scanning / CodeQL
File data in outbound network request Medium
elliotCamblor
changed the title
elliotCamblor
force-pushed
the
COR-3013-feature-importer-v2-endpoints
branch
from
61eea77 to
d3f991a
Compare
elliotCamblor
force-pushed
the
COR-3013-feature-importer-v2-endpoints
branch
from
d3f991a to
3d5e453
Compare
Co-authored-by: Kaushal Kapasi <[email protected]>
kaushalkapasi
approved these changes
Oct 4, 2024
| options: { throwOnError: boolean } = { throwOnError: true } | ||
| ): Promise<FeatureConfiguration> { | ||
| const headers = await this.getHeaders() | ||
| const response = await fetch( | ||
| `${DVC_BASE_URL}/projects/${projectKey}/features/${featureKey}/configurations?environment=${environment}`, | ||
| `${DVC_BASE_URL_V2}/projects/${projectKey}/features/${feature.key}`, |
Check warning
Code scanning / CodeQL
File data in outbound network request Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.