Skip to content

Commit

Permalink
chore: update 'platform' to return 'C#' not including 'Local' / 'Clou…
Browse files Browse the repository at this point in the history
…d' to match other SDK formats.
  • Loading branch information
jonathannorris committed Mar 15, 2024
1 parent 25dff6c commit 8818196
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion DevCycle.SDK.Server.Cloud.MSTests/DevCycleTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ public void User_NullUserId_ThrowsException()

private void AssertUserDefaultsCorrect(DevCycleUser user)
{
Assert.AreEqual("C# Cloud", user.Platform);
Assert.AreEqual("C#", user.Platform);
Assert.AreEqual(DevCycleUser.SdkTypeEnum.Server, user.SdkType);
//Assert.AreEqual("1.0.3.0", user.SdkVersion);
}
Expand Down
2 changes: 1 addition & 1 deletion DevCycle.SDK.Server.Common/API/DevCycleBaseClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace DevCycle.SDK.Server.Common.API
{
public abstract class DevCycleBaseClient : IDevCycleClient
{
public string SdkPlatform => $"C# {Platform()}";
public string SdkPlatform => $"C#";
private static string CSharpVersion => System.Runtime.InteropServices.RuntimeInformation.FrameworkDescription;
private static string SdkVersion => typeof(IDevCycleClient).Assembly.GetName().Version.ToString();
private static DevCycleUser.SdkTypeEnum SdkType => DevCycleUser.SdkTypeEnum.Server;
Expand Down
3 changes: 1 addition & 2 deletions DevCycle.SDK.Server.Common/Model/Local/PlatformData.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ namespace DevCycle.SDK.Server.Common.Model.Local
{
public class PlatformData
{

private const string DefaultPlatform = "C# Local";
private const string DefaultPlatform = "C#";
private const DevCycleUser.SdkTypeEnum DefaultSdkType = DevCycleUser.SdkTypeEnum.Server;

private static readonly string DefaultSdkVersion = typeof(DevCyclePopulatedUser).Assembly.GetName().Version.ToString();
Expand Down

0 comments on commit 8818196

Please sign in to comment.