fix numeric type

DevCycleHQ · Oct 26, 2023 · 6bccfb2 · 6bccfb2
1 parent a07a5ee
commit 6bccfb2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/DevCycle.SDK.Server.Common/Model/OpenFeatureValueJsonConverter.cs b/DevCycle.SDK.Server.Common/Model/OpenFeatureValueJsonConverter.cs
@@ -40,7 +40,7 @@ public override Value Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSe
                 case JsonTokenType.String:
                     return new Value(reader.GetString());
                 case JsonTokenType.Number:
-                    return new Value(reader.GetDecimal());
+                    return new Value(reader.GetDouble());
                 case JsonTokenType.True:
                     return new Value(true);
                 case JsonTokenType.False:

diff --git a/DevCycle.SDK.Server.Local.MSTests/DevCycleTest.cs b/DevCycle.SDK.Server.Local.MSTests/DevCycleTest.cs
@@ -382,7 +382,8 @@ public void TestOpenFeatureSerialization()
             {
                 { "key", new Value("value") },
                 { "key2", new Value(new Structure(simpleDict)) },
-                { "listKey", new Value(listDict) }
+                { "listKey", new Value(listDict) },
+                {"numberKey", new Value(1d)}
             };
 
             var defaultV = new Value(new Structure(jsonDict));
@@ -395,6 +396,7 @@ public void TestOpenFeatureSerialization()
             Assert.AreEqual(defaultV.IsStructure, deserialzed.IsStructure);
             Assert.AreEqual(defaultV.AsStructure.GetValue("key").AsString,
                 deserialzed.AsStructure.GetValue("key").AsString);
+            Assert.AreEqual(1, deserialzed.AsStructure.GetValue("numberKey").AsInteger);
         }
     }
 }