Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to Angular v18 #325

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

LakhveerChahal
Copy link

@LakhveerChahal LakhveerChahal commented May 25, 2024

@DethAriel Please have a look at the changes and let me know in case of any doubts/concerns.

@LakhveerChahal LakhveerChahal marked this pull request as ready for review May 25, 2024 08:25
@LakhveerChahal LakhveerChahal changed the title upgrade to Angular v18 closes #324 upgrade to Angular v18 May 25, 2024
@ranbuch
Copy link

ranbuch commented Jun 6, 2024

@DethAriel Is there a timeline for this PR?

@LakhveerChahal
Copy link
Author

For those who want it urgently:
Published it as a new library under the name ng-recaptcha-2

@ms-dosx86
Copy link

@LakhveerChahal If you need it so badly why don't you just run npm i --legacy-peer-deps? It's kinda ugly but fine as a temporary solution.

@LakhveerChahal
Copy link
Author

As you said, it's ugly and I was kind of losing hope that this PR will get merged anytime soon.

@KissBalazs
Copy link

Hi! Is there any reason why this is still not merged? We would like to avoid using the old deps approach for stability reasons.

@MarcosPaulo775
Copy link

Is there a scheduled date for the merge?

@fast-facts
Copy link

Hi! Is there any reason why this is still not merged? We would like to avoid using the old deps approach for stability reasons.

Because this is abandonware

@carriquiry-g
Copy link

For those who want it urgently: Published it as a new library under the name ng-recaptcha-2

In case any one missed it, this is the same library but with the merge completed. I don't know if @LakhveerChahal will maintain it in the future, but it solves the issue until the next version of Angular drops

@LakhveerChahal
Copy link
Author

For those who want it urgently: Published it as a new library under the name ng-recaptcha-2

In case any one missed it, this is the same library but with the merge completed. I don't know if @LakhveerChahal will maintain it in the future, but it solves the issue until the next version of Angular drops

I'll try my best to keep it up to date with latest Angular.

@carriquiry-g
Copy link

I'll try my best to keep it up to date with latest Angular.

Happy to help keeping it up to date

@avatier-leonardoc
Copy link

Please, merge this.

@jurvi
Copy link

jurvi commented Oct 5, 2024

@DethAriel Any chance we could get this one rolling? Kinda want to upgrade my project to ng 18 but don't want to do silly workarounds with legacy peer deps.

@loutocky
Copy link

merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.