fix(component): correct type when using strict mode #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an application that depends on ng-recaptcha has tsconfig.json
"strictNullChecks": true
the `Parameters<T>` utility type fails if the type parameter allows `undefined`.
Closes DethAriel#211
|
Hey folks! Sorry, been busy, I’ll merge this tomorrow and release a fixed
version. Thx for the find @bbarry !!
…On Wed, Jan 6, 2021 at 6:35 PM Yehuda Ringler ***@***.***> wrote:
For the curious, you can use @bbarry <https://github.com/bbarry> s fork
until this is merged
with yarn:
"ng-recaptcha": "
https://github.com/bbarry/ng-recaptcha#65040f15359f229c0aefe76bfe015ec9cced183c
"
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#212 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALNVPIDZY7ISRBNQY2LHWTSYUMY5ANCNFSM4VWDBZCA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an application that depends on ng-recaptcha has tsconfig.json
the
Parameters<T>utility type fails if the type parameter allowsundefined.Closes #211