Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes I get this error: Cannot read property 'unsubscribe' of undefined #46

Closed
dockleryxk opened this issue Aug 11, 2017 · 0 comments
Closed

Sometimes I get this error: Cannot read property 'unsubscribe' of undefined #46

dockleryxk opened this issue Aug 11, 2017 · 0 comments

Comments

@dockleryxk
Copy link
Contributor

Since that other guy isn't going to do it, I will. The issue is completely explained in the title. PR to follow
dockleryxk added a commit to dockleryxk/ng-recaptcha that referenced this issue Aug 11, 2017
@dockleryxk
bug(ngOnDestroy): add an if statement to make sure this.subscription is
c4f4c68 
defined

This simply allows navigation away from a route using this package which
is not currently happening every time.

Closes DethAriel#46
@dockleryxk dockleryxk mentioned this issue Aug 11, 2017
Merged
dockleryxk added a commit to dockleryxk/ng-recaptcha that referenced this issue Aug 11, 2017
@dockleryxk
bug(ngOnDestroy): add an if statement to make sure this.subscription is
92c6723 
defined

This simply allows navigation away from a route using this package which
is not currently happening every time.

Closes DethAriel#46
DethAriel pushed a commit that referenced this issue Aug 18, 2017
@dockleryxk @DethAriel
bug(ngOnDestroy): add an if statement to make sure this.subscription is
9cc48ab 
defined

This simply allows navigation away from a route using this package which
is not currently happening every time.

Closes #46
DethAriel pushed a commit that referenced this issue Aug 18, 2017
@dockleryxk @DethAriel
fix(component): ensure that component is destroyed safely
1e51d56 
Add an if statement to make sure this.subscription is defined.
This ensures safe component destruction in case it hasn't been fully initialized yet.

Closes #46
dockleryxk added a commit to dockleryxk/ng-recaptcha that referenced this issue Sep 20, 2017
@dockleryxk
fix(component): ensure that component is destroyed safely
808f6bb 
Add an if statement to make sure this.subscription is defined.
This ensures safe component destruction in case it hasn't been fully initialized yet.

Closes DethAriel#46

chore(package): remove dev dependency on `@types/grecaptcha`

chore(demo): add clarifying comments for local debugging

docs(contrib): add contribution guidelines

closes DethAriel#42

docs(readme): remove rename notice from readme

Consumers had enough time to get learn about this change


feat(component): add the ability to specify component props globally

Now consumers can specify some of the `<re-captcha>` properties globally, including `siteKey`.

closes DethAriel#45

docs(demo): add example for specifying properties globally


chore(package): bump version to 2.2.0

fix(component): fix server-side rendering

Change the RecaptchaLoaderService to render the recaptcha script tag only in a browser environment.

Closes DethAriel#34

BREAKING CHANGE:
Angular v2.x.x is no longer supported due to dependency on Platform capabilities that were added in [v4.0.0-rc.1](https://github.com/angular/angular/blob/master/CHANGELOG.md#features-20)

docs(demo): fix active tab reference for global config example

chore(package): Future-proofing for Angular v5

build(package): fix builds by tweaking `tslint`

Update `tslint` dependency strategy to be tilde instead of caret to overcome potential breakage when new rules are added

chore(package): bump version to 3.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dockleryxk