Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flesh out some further deployment integration #1081

Merged
merged 17 commits into from
Aug 8, 2024
Merged

flesh out some further deployment integration #1081

merged 17 commits into from
Aug 8, 2024

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Aug 8, 2024

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

grahamc
grahamc commented Aug 8, 2024
View reviewed changes
flake.nix Outdated Show resolved Hide resolved
@grahamc grahamc marked this pull request as ready for review August 8, 2024 15:55
@grahamc grahamc force-pushed the dnixdm branch 2 times, most recently from 5ac9604 to 7daf7ee Compare August 8, 2024 16:21
@grahamc
Update determinate flake to have an x86_64-darwin build
ec9b13d
@grahamc
Embed determinate-nixd for aarch64-darwin and x86_64-darwin
30b67b5
@grahamc
Don't check to see if dnixd is already installed ahead of time, we've…
16177bc 
… got it.
@grahamc
Set the const on everything but x86 linux
838b6bd
@grahamc
Move the ProvisionDeterminateNixd plan step to Common
4bde5a6
@grahamc
CreateDirectory: don't fail if the dir exists already, so we can crea…
b1f0800 
…te /etc/nix before mounting too
@grahamc
create determinate nix volume: create /etc/nix before mounting
10e18b7
@grahamc
Move service writing on Linux from ProvisionDeterminateNixd to Config…
e859b5b 
…ureDeterminateNixd
@grahamc
Move ProvisionDeterminateNixd to before we create the volume on macOS…
a3e9ac5 
…, since we use it for mounting.
@grahamc
Remove checkpolicy from the Linux dev shell as it is broken
3728a06
cole-h
cole-h requested changes Aug 8, 2024
View reviewed changes
flake.nix Outdated Show resolved Hide resolved
src/action/common/provision_determinate_nixd.rs Outdated Show resolved Hide resolved
src/settings.rs Show resolved Hide resolved
src/settings.rs Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
cole-h
cole-h reviewed Aug 8, 2024
View reviewed changes
flake.nix Outdated Show resolved Hide resolved
@grahamc
Actuall do the thing: break out the list of supported systems into a …
f963a6e 
…list, put it next to the overall supportedSystems
@grahamc grahamc merged commit 3f59a12 into main Aug 8, 2024
16 checks passed
@grahamc grahamc deleted the dnixdm branch August 8, 2024 20:29
@cole-h cole-h added this to the 0.21.0 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

@lucperkins lucperkins lucperkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@grahamc @lucperkins @cole-h