Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop a ton of target_os based cfg's to allow more tests and clippies to be caught cross-platform #1058

Merged
merged 11 commits into from
Jul 23, 2024
Merged

Drop a ton of target_os based cfg's to allow more tests and clippies to be caught cross-platform #1058

merged 11 commits into from
Jul 23, 2024

Commits on Jul 23, 2024

  1. First large swath of un-cfg'ing target os

    @grahamc
    grahamc committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    0f36ddd View commit details
    Browse the repository at this point in the history

  2. Kill more cfg(target_os, this time the tests pass

    @grahamc
    grahamc committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    ddb82bd View commit details
    Browse the repository at this point in the history

  3. Drop more cfg target_os, tests pass

    @grahamc
    grahamc committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    599e328 View commit details
    Browse the repository at this point in the history

  4. Drop the remaining target_os cfg's that aren't strictly host tuning

    @grahamc
    grahamc committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d4c7cb7 View commit details
    Browse the repository at this point in the history

  5. Create a host-specific planner struct to restrict what can be passed … 

    …to clap
    @grahamc
    grahamc committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    7ef2d96 View commit details
    Browse the repository at this point in the history

  6. Ostree

    @grahamc
    grahamc committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    37d451a View commit details
    Browse the repository at this point in the history

  7. Drop the HostSpecificBuiltinPlanner enum and add a platform_check to … 

    …the planner impl
    @grahamc
    grahamc committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5fcf87a View commit details
    Browse the repository at this point in the history

  8. Hide the planners based on the target os

    @grahamc
    grahamc committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    578a901 View commit details
    Browse the repository at this point in the history

  9. derp

    @grahamc
    grahamc committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    116093b View commit details
    Browse the repository at this point in the history

  10. Move up the platform check on plan, to eliminate platform incompatibi… 

    …lities before getting fancy with the planner
    @grahamc
    grahamc committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d583f86 View commit details
    Browse the repository at this point in the history

  11. make the error type have context about the planner and host os

    @grahamc
    grahamc committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    107bac5 View commit details
    Browse the repository at this point in the history