-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary support for macOS 15 beta #1038
Conversation
It's the same in every branch, so let's inline it at the one place it matters.
This may have implications for unattended setups that we'll want to explore at a later date.
@@ -207,46 +208,81 @@ pub struct CommonSettings { | |||
pub diagnostic_endpoint: Option<String>, | |||
} | |||
|
|||
#[derive(Deserialize, Clone, Debug, PartialEq)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be great to move this into its own module, since it isn't really belonging here. Otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's a better place to put it, but open to suggestions.
Sequoia currently mangles users in the old range on upgrade; I think it would be best if we could pick a single range to use for all versions to avoid breaking people’s setups when they upgrade their OS. (Though there are so many existing installations that it might be somewhat futile.) |
Can you clarify what you mean by how it mangles them? We're going with the 450 range for now to make it work for our users who need it now, while also working to figure out a good plan for the whole userbase. We're already documenting the flag for overriding it, so making it do this by default isn't making the problem worse -- just makes the users less annoyed |
(btw, we're taking this approach so we can help our users while continuing to collaborate with upstream on a unified approach) |
Fair enough, I agree that this is better than the previous status quo – just wasn’t sure if it was meant to fix the ranges for good :) I hope to get the time to test upgrade behaviour and potential ID ranges more thoroughly and hopefully we can settle on values as an ecosystem soon; it’s been a busy time. Re: mangling, my understanding is that it just rewrites them with its new system users (maybe leaving the old ones around with no UID assignment or something weird like that?). Everything kind of just breaks and the error messages are confusing. So unless Apple adjust something by the time of the final Sequoia release it’s going to be mayhem when it drops, even if we have polished migration tools in place. |
@emilazy Earlier I got myself into the mangled state you described, hence me ending up here. Here's a bit of info if helpful:
After upgrade, ran into this error when attempting again:
I've never really looked much into the underlying Nix install setup. But here's some other details in case they're relevant:
I was going to entirely reinstall nix, but will leave it in this state overnight in case there's any commands you want me to run to collect additional data when I wake up. |
Description
Ref #1001
Checklist
cargo fmt
nix build
nix flake check
Validating with
install.determinate.systems
If a maintainer has added the
upload to s3
label to this PR, it will become available for installation viainstall.determinate.systems
: