Merge pull request #10811 from DestinyItemManager/reverse-it

Correctly reverse failed save search / revamp dim-api tests
DestinyItemManager · Nov 27, 2024 · ef6149d · ef6149d
2 parents a19bffd + 24c87bb
commit ef6149d
Show file tree

Hide file tree

Showing 3 changed files with 695 additions and 628 deletions.
diff --git a/src/app/dim-api/api-types.ts b/src/app/dim-api/api-types.ts
@@ -1,15 +1,17 @@
 import {
   DeleteLoadoutUpdate,
+  DeleteSearchUpdate,
   DestinyVersion,
   Loadout,
   ProfileUpdate,
+  SearchType,
 } from '@destinyitemmanager/dim-api-types';
 
 // https://stackoverflow.com/questions/51691235/typescript-map-union-type-to-another-union-type
 type AddUpdateInfo<U> = U extends ProfileUpdate
   ? U & {
       /** The state before this update - if it fails we can use this to roll back */
-      before?: U['payload'];
+      before: U['payload'] | undefined;
       /** The account (if any) this update refers to */
       platformMembershipId?: string;
       destinyVersion?: DestinyVersion;
@@ -22,9 +24,20 @@ export interface DeleteLoadoutUpdateWithRollback extends DeleteLoadoutUpdate {
   destinyVersion: DestinyVersion;
 }
 
+export interface DeleteSearchUpdateWithRollback extends DeleteSearchUpdate {
+  before: {
+    query: string;
+    type: SearchType;
+    saved: boolean;
+  };
+  platformMembershipId: string;
+  destinyVersion: DestinyVersion;
+}
+
 /**
  * A version of ProfileUpdate that also includes rollback info in a "before" property.
  */
 export type ProfileUpdateWithRollback =
+  | DeleteSearchUpdateWithRollback
   | DeleteLoadoutUpdateWithRollback
   | AddUpdateInfo<ProfileUpdate>;