This repository has been archived by the owner on May 5, 2020. It is now read-only.
Fix compatibility with Twisted 16.4.1 (and possibly earlier versions). #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twisted now calls pauseProducing() when it finishes receiving the request. For txsockjs to continue receiving data from the transport, it now needs to call resumeProducing(). This should have no effect on earlier versions of Twisted.
|
I can confirm that this fixes my problem when using twisted 16.4 and leads to no problem when using twisted 14.0. |
|
The change seems to have happened between 16.2 and 16.3 as far as I could tell. I was planning on trying to bisect it this week. |
|
Twisted's behavior changed with the nice new HTTP 2 code. Unfortunately, txsockjs is using undocumented interfaces that were affected by HTTP 2. Fortunately, Twisted didn't change very much, so I'm OK with relying on these particular undocumented interfaces for a while. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twisted now calls pauseProducing() when it finishes receiving the request. For txsockjs to continue receiving data from the transport, it now needs to call resumeProducing(). This should have no effect on earlier versions of Twisted.
See also:
https://twistedmatrix.com/trac/ticket/8320#comment:23
https://twistedmatrix.com/trac/ticket/3204