Fix endian issues with iff importer.

[MaddTheSane]

Pull Request Type

• GitHub Workflow changes
• Documentation or Wiki changes
• Build and Dependency changes
• Runtime changes
  • Render changes
  • Audio changes
  • Input changes
  • Network changes
  • Other changes

Description

There were a couple of places that weren't byte-swapped on little-endian systems. And due to cf_ReadInt and cf_ReadShort automatically calling INTEL_INT which then byte-swaps the value on big-endian machines, the next calls to MOTOROLA_SHORT and MOTOROLA_INT don't swap the value because it's on a big-endian machine.

Checklist

• I have tested my changes locally and verified that they work as intended.
• I have documented any new or modified functionality.
• I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
• I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

[winterheart]

I'd recommend implement additional cf_ReadShortBE() and cf_ReadIntBE() or extend current cf_ReadShort() and cf_ReadInt() with optional parameter little_endian in CFILE module like this:

// Declaration in cfile.h
int32_t cf_ReadInt(CFILE *cfp, bool little_endian = true);

// Implementation in cfile.cpp
int32_t cf_ReadInt(CFILE *cfp, bool little_endian) {
  int32_t i;
  cf_ReadBytes((uint8_t *)&i, sizeof(i), cfp);
  return (little_endian ? INTEL_INT(i) : MOTOROLA_INT(i));
}

After that you can use it without additional conversion code in iff

[winterheart]

Tested on Linux, no regression found.