Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate misc module #470

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

winterheart
Copy link
Collaborator

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Isolate misc module for better dependency handling. This change needed for upcoming cfile unittest framework.

Related Issues

Screenshots (if applicable)

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

@winterheart winterheart force-pushed the misc-isolate branch 4 times, most recently from c24fb54 to bde6065 Compare June 26, 2024 22:01
Isolate misc module for better dependency handling.
@Lgt2x Lgt2x self-assigned this Jun 27, 2024
Copy link
Member

@Lgt2x Lgt2x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, works on Linux. misc may not be a very good name, but I don't have a better idea right now. Should we create a dedicated logging module and one for error handling?

@Lgt2x Lgt2x merged commit b1caee7 into DescentDevelopers:main Jun 28, 2024
12 checks passed
@winterheart
Copy link
Collaborator Author

winterheart commented Jun 28, 2024

Probably yes. I think logging facility would be header-only macros. Error handling troubles me - it requires SDL for SDL_Assert() and effectively pulls it to all dependent modules.

@winterheart winterheart deleted the misc-isolate branch August 12, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants