Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GLOB_PERIOD from ddio_FindFileStart #462

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

tophyr
Copy link
Contributor

@tophyr tophyr commented Jun 24, 2024

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

GLOB_PERIOD is a GNU extension and is not supported on non-glibc. This shouldn't dramatically affect any file behaviors.

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

GLOB_PERIOD is a GNU extension and is not supported on non-glibc
Copy link
Member

@Lgt2x Lgt2x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed ddio_FindFileStart usages, there does not seem to be any supposed to explicitely match .. This should be fine.

@Lgt2x Lgt2x merged commit ed79350 into DescentDevelopers:main Jun 24, 2024
12 checks passed
@tophyr tophyr deleted the gno-gnu-glob branch June 26, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants