Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mem module isolated from project #448

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Make mem module isolated from project #448

merged 1 commit into from
Jun 22, 2024

Conversation

winterheart
Copy link
Collaborator

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Properly define MEM_USE_RTL definition only for mem library. Link other dependent modules with mem.

Related Issues

Closes #447

Screenshots (if applicable)

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

@winterheart
Make mem module isolated from project
db8aa64 
Properly define MEM_USE_RTL definition only for mem library. Link other dependant modules with mem.
Lgt2x
Lgt2x reviewed Jun 20, 2024
View reviewed changes
mem/CMakeLists.txt
@@ -1,5 +1,13 @@
set(HEADERS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mem.h can go there, otherwise target_include_directories is useless

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#411 should take care of this, nothing important

Lgt2x
Lgt2x approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@Lgt2x Lgt2x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, tested on Win32, you don't seem to have any link library missing

mem/CMakeLists.txt
@@ -1,5 +1,13 @@
set(HEADERS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#411 should take care of this, nothing important

@Lgt2x Lgt2x merged commit c515189 into DescentDevelopers:main Jun 22, 2024
12 checks passed
@winterheart winterheart deleted the mem-module branch August 12, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lgt2x Lgt2x Lgt2x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ENABLE_MEM_RTL a target define
2 participants
@winterheart @Lgt2x