-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create THIRD_PARTY.md for external code handling #435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR would benefit from a more in depth commit message. At the moment, the commit message explains what the changes are, but it doesn’t explain why the changes were made. Here’s a list of things that I would include in the commit message:
- I would include an explanation of what the problem in Fixed failing MSVC build #429 was and an explanation of what the commit does to fix it.
- I would also include an explanation of why the
third_party_licenses/
directory was replaced withTHIRD_PARTY.md
. (Personally, I would rather keep each license in its own file, but if there’s a good reason to put them all in one file, then I’m all ears). - I would also include an explanation of why the MIT License was chosen for stb. The upstream stb repo says “This software is available under 2 licenses -- choose whichever you prefer”, and this PR chooses one of the licenses over the other. I would add an explanation of why one of the two licenses was included in
THIRD_PARTY.md
but not the other.
Added all external code and license notices. Install THIRD_PARTY.md on installation step.
STB licensed under MIT because MIT is compatible with GPLv3, while public domain may require additional explanations for re-licensing. I prefer to use clear statement on license compatibility. |
I agree that the MIT License is clearly compatible with the GPLv3. After all, the GNU Project has an official GPL compatibilty list, and the MIT License is on that list. That being said, I don’t see why a public domain dedication would require additional explanations. That same GPL compatibility list specifically says both public domain code in general and Unlicensed code in particular are GPL compatible. What makes the MIT License’s GPL compatibility more clear than the Unlicense’s GPL compatibility? |
|
If that’s the reason why this PR only uses the MIT License for stb, then I would put that reason into the commit message. I think that that reason is stronger than the clarity thing, although I still don’t fully understand the clarity thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, files install correctly
Pull Request Type
Description
Added all external code and license notices. Install THIRD_PARTY.md on installation step.
Related Issues
Closes #429.
Screenshots (if applicable)
Checklist
Additional Comments