Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup: Add one macro, remove five others #408

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

GravisZro
Copy link
Contributor

Description

  • Add macro PRIMARY_HOG to define the hardcoded hog filename to load.
  • Replace instances of LINUX with __LINUX__
  • Replace #elif __LINUX__ with #else because otherwise it omits code completely.
  • Remove these macros entirely because they are (now) unused
    • LINUX
    • _REENRANT
    • __32BIT__
  • Removed from primary CMakeFile.txt because they defined in linux_fix.h
    • _MAX_PATH=260
    • _MAX_FNAME=256

Pull Request Type

  • Build and Dependency changes

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

- Add macro PRIMARY_HOG to define the hardcoded hog filename to load.
- Replace instances of "LINUX" with "__LINUX__"
- Remove these macros entirely because they are (now) unused
  - LINUX
  - _REENRANT
  - __32BIT__
- Removed from CMakeFile.txt because they are in linux_fix.h
  - _MAX_PATH=260
  - _MAX_FNAME=256
@GravisZro GravisZro force-pushed the remove/unusedpredefs branch from 6fb97dd to bfe52bc Compare May 31, 2024 16:05
@Lgt2x Lgt2x merged commit 6d3a4c3 into DescentDevelopers:main Jun 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants