Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reordering linux modules, cleanup code #367

Merged
merged 6 commits into from
May 22, 2024

Conversation

winterheart
Copy link
Collaborator

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Reordering some Linux related modules, cleanup code and use standardized C99 functions.

Related Issues

Screenshots (if applicable)

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

@JeodC JeodC requested a review from Lgt2x May 19, 2024 13:17
@JeodC JeodC added the cleanup Code cleanup label May 19, 2024
@winterheart winterheart mentioned this pull request May 22, 2024
13 tasks
Copy link
Member

@Lgt2x Lgt2x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this module cleanup! We were discussing it the other day

@@ -29,7 +29,7 @@
#include <io.h>
#else
// Linux Build Includes
#include "linux/linux_fix.h"
#include "linux_fix.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really hating this fix that's been put everywhere just for a couple of non cross platform string functions. I hope we find a way to get rid of it in the future.

@Lgt2x Lgt2x merged commit f5d5ea9 into DescentDevelopers:main May 22, 2024
10 checks passed
@winterheart winterheart deleted the lnxcontroller branch May 27, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants