Replace ioctl with fcntl, fix ioctlsocket calls (64-bit fix)

[GravisZro]

These take two different types of arguments but worked in the past due to long being 32-bit.

Pull Request Type

• GitHub Workflow changes
• Documentation or Wiki changes
• Build and Dependency changes
• Runtime changes
  • Render changes
  • Audio changes
  • Input changes
  • Network changes
  • Other changes

Description

The ioctl argument for UNIX systems is int* while the ioctlsocket argument for Windows is unsigned long*. On 32-bit systems theses coincided so no problems but not on 64-bit. However, the behavior of ioctl calls is non-standard which is why code should use fnctl.

See also:

• ioctlsocket documentation
• fnctl documentation
• ioctl documentation

Checklist

• I have tested my changes locally and verified that they work as intended.
• I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
• I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

[winterheart]

I would rewrite socket initialization as

#ifdef WIN32

dedicated_listen_socket = socket(AF_INET, SOCK_STREAM, 0);

// ...

unsigned long arg = 1;
ioctlsocket(dedicated_listen_socket, FIONBIO, &arg);

#else // WIN32

#ifndef SOCK_NONBLOCK
#include <fcntl.h>
#define SOCK_NONBLOCK O_NONBLOCK
#endif

dedicated_listen_socket = socket(AF_INET, SOCK_STREAM | SOCK_NONBLOCK, 0);

#endif

And you don't have to use additional fcntl(..., F_SETFL (fcntl(..., F_GETFL) )) calls on Linux / macOS platforms. There a plenty code duplication around socket initialization, so would be some helper functions would be useful.

[GravisZro]

@winterheart Not all of these are socket initializations. As such, I consolidated the code into a single function in networking.h. Including networking.h in other headers lead to conflicting duplicate code which is why there are now code deletions.

[jcoby]

This should probably be called something like nw_SocketSetNonblock() to match the rest of the functions defined here.

[GravisZro]

It was considered but it's used on other sockets as well where the nw_* scheme wouldn't be appropriate.

[GravisZro]

Would someone please merge this? It's been reviewed by two people already.

[winterheart]

PR has regression on Linux, see #398.