Mark functions and variables as static #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaddTheSane
force-pushed
the
staticFuncs
branch
3 times, most recently
from
d4560ca to
01a7f76
Compare
Lgt2x
reviewed
Apr 28, 2024
Jayman2000
suggested changes
May 3, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Lgt2x
reviewed
May 6, 2024
Lgt2x
approved these changes
May 6, 2024
Move paged_in_count and paged_in_num to gamesequence.h Move DoneLightInstance and StartLightInstance to polymodel.h
Jayman2000
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are variables and functions that are only used in their own source file.
This also moves some
externdeclarations in source files to relevant headers.I also marked functions that I couldn't find any place it was used in Descent 3 (mostly light map generation) but might be used elsewhere (The editor, perhaps?).