Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for misplaced (identifier) aliases & missing literals #102

Merged

Conversation

LeoniePhiline
Copy link
Contributor

@LeoniePhiline LeoniePhiline commented Feb 18, 2023

The changes are intentionally divided into clean commits (with tests for each).

Thus, the commits are best reviewed individually.

This PR fixes all issues mentioned in #101.


I added 756ffc2 as a fix for #103.

@LeoniePhiline LeoniePhiline force-pushed the fix/unnecessary-identifiers branch from 44ffd90 to e4e43ba Compare February 18, 2023 18:21
@LeoniePhiline LeoniePhiline mentioned this pull request Feb 18, 2023
@LeoniePhiline LeoniePhiline marked this pull request as ready for review February 18, 2023 18:28
@LeoniePhiline
Copy link
Contributor Author

@DerekStride Ready for review.

@DerekStride DerekStride merged commit 3a3f92b into DerekStride:main Feb 19, 2023
@matthias-Q
Copy link
Collaborator

The changes on cast and count will break the highlighting in nvim-treesitter

@matthias-Q
Copy link
Collaborator

@LeoniePhiline yes, I have a pending PR there: nvim-treesitter/nvim-treesitter#4323

I will add these changes as well. However I would like to have it merged rather sooner than later because I keep adding changes in order to keep up with upstream changes.

@DerekStride can you do another look in that PR in order to get it approved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants