-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for misplaced (identifier)
aliases & missing literals
#102
Fixes for misplaced (identifier)
aliases & missing literals
#102
Conversation
44ffd90
to
e4e43ba
Compare
@DerekStride Ready for review. |
The changes on |
@matthias-Q I assume they must be adjusted. The nvim queries are quite outdated. You'll need to adjust https://github.com/nvim-treesitter/nvim-treesitter/blob/master/queries/sql/highlights.scm for nvim, as I do for hx: In reverse chronological order:
|
@LeoniePhiline yes, I have a pending PR there: nvim-treesitter/nvim-treesitter#4323 I will add these changes as well. However I would like to have it merged rather sooner than later because I keep adding changes in order to keep up with upstream changes. @DerekStride can you do another look in that PR in order to get it approved? |
The changes are intentionally divided into clean commits (with tests for each).
Thus, the commits are best reviewed individually.
This PR fixes all issues mentioned in #101.
I added 756ffc2 as a fix for #103.