-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement wrapper around KafkaConsumer
to support batch consumption with head of line blocking
#907
Labels
component/api-server
enhancement
New feature or request
p3
Nice-to-have features
size/L
High effort
spike/research
Requires more research before implementation
Comments
I just realized that Confluent's Parallel Consumer is doing exactly that: #346 Update: Confluent Parallel Consumer has no batch timeout behavior (doesn't wait for batches to become full). So ultimately we need to build our own batching consumer. But perhaps PC can be used as intermediary solution in the meantime. |
Closed
3 tasks
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 2, 2024
Decoupled from #509 This merely adds an API on top of which processors can be implemented. We can migrate processors one-by-one from Kafka Streams to this API. Majority of this work was already done in #509, but got out of date due to changed priorities. At the very least said PR is good to take inspiration from. Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
2 tasks
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 3, 2024
Decoupled from #509 This merely adds an API on top of which processors can be implemented. We can migrate processors one-by-one from Kafka Streams to this API. Majority of this work was already done in #509, but got out of date due to changed priorities. At the very least said PR is good to take inspiration from. Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 5, 2024
Decoupled from #509 This merely adds an API on top of which processors can be implemented. We can migrate processors one-by-one from Kafka Streams to this API. Majority of this work was already done in #509, but got out of date due to changed priorities. At the very least said PR is good to take inspiration from. Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 5, 2024
Decoupled from #509 This merely adds an API on top of which processors can be implemented. We can migrate processors one-by-one from Kafka Streams to this API. Majority of this work was already done in #509, but got out of date due to changed priorities. At the very least said PR is good to take inspiration from. Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 5, 2024
… Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 5, 2024
… Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
2 tasks
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 5, 2024
Decoupled from #509 This merely adds an API on top of which processors can be implemented. We can migrate processors one-by-one from Kafka Streams to this API. Majority of this work was already done in #509, but got out of date due to changed priorities. At the very least said PR is good to take inspiration from. Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 5, 2024
… Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 5, 2024
…l Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 5, 2024
… Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
2 tasks
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 5, 2024
Decoupled from #509 This merely adds an API on top of which processors can be implemented. We can migrate processors one-by-one from Kafka Streams to this API. Majority of this work was already done in #509, but got out of date due to changed priorities. At the very least said PR is good to take inspiration from. Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 5, 2024
… Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 5, 2024
…l Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 9, 2024
… Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 9, 2024
…l Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 26, 2024
… Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 26, 2024
…l Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 26, 2024
… Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Feb 26, 2024
…l Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Mar 4, 2024
… Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Mar 4, 2024
…l Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Mar 19, 2024
… Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Mar 19, 2024
… Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Mar 19, 2024
…l Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
2 tasks
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Mar 22, 2024
…l Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this issue
Mar 25, 2024
…l Consumer Depends on #552 Relates to DependencyTrack/hyades#346 Relates to DependencyTrack/hyades#901 Relates to DependencyTrack/hyades#907 Signed-off-by: nscuro <[email protected]>
2 tasks
Closing, as consumers in the API server have been migrated to Confluent parallel-consumer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/api-server
enhancement
New feature or request
p3
Nice-to-have features
size/L
High effort
spike/research
Requires more research before implementation
We have multiple use cases where Kafka records are assembled into batches before they're processed.
While batch semantics can be achieved with Kafka Streams, it introduces additional overhead:
An example of trying to address such batching use cases in Kafka Streams can be seen here: https://github.com/DependencyTrack/hyades-apiserver/pull/305/files
For simple batching use cases, ideally it should work like this:
foo
poll
records from all N partitionsEssentially, implement a batch consumer with head-of-line blocking.
HOL blocking semantics are often undesirable, but for certain cases they are useful:
Areas where I think this might be useful:
ScanResult
s and vulnerabilities from thedtrack.vuln-analysis.result
topicAnalysisResult
s from thedtrack.repo-meta-analysis.result
topicScanResult
s when tracking vulnerability scan completion (see https://github.com/DependencyTrack/hyades-apiserver/pull/305/files)dtrack.vulnerability
topicThe text was updated successfully, but these errors were encountered: