Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: Global Audit View for vulnerabilities #723

Merged
merged 4 commits into from
Jun 16, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Jun 13, 2024

Description

This PR introduces introduces new API endpoints in the FindingResource of the backend. These two new endpoints filter every finding by ACLs and other optional filters and then returns them , either by occurrence of vulnerability or grouped by vulnerability.

Addressed Issue

Backport change DependencyTrack/hyades#1190

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Copy link

codacy-production bot commented Jun 13, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.10% (target: -1.00%) 72.13% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (df57c53) 19893 16217 81.52%
Head commit (8e04db2) 20178 (+285) 16429 (+212) 81.42% (-0.10%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#723) 244 176 72.13%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@sahibamittal sahibamittal marked this pull request as ready for review June 13, 2024 15:06
@sahibamittal
Copy link
Collaborator Author

sahibamittal commented Jun 13, 2024

Tested with frontend https://github.com/DependencyTrack/hyades-frontend/tree/rebase-v4.11.3

Screenshot 2024-06-13 at 16 06 43 Screenshot 2024-06-13 at 16 08 02

@sahibamittal sahibamittal added v4-port PRs that were ported from the Dependency-Track v4.x code base enhancement New feature or request labels Jun 14, 2024
@nscuro nscuro added this to the 5.5.0 milestone Jun 16, 2024
@nscuro nscuro changed the title Backport : Global Audit View for vulnerabilities Port: Global Audit View for vulnerabilities Jun 16, 2024
@nscuro nscuro merged commit 1dee6fe into main Jun 16, 2024
9 checks passed
@nscuro nscuro deleted the port-global-audit-view-for-vulnerabilities branch June 16, 2024 17:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants