Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: Fix jira and slack notification #703

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Jun 7, 2024

Description

Changed "subject.dependency.project.name" to
"subject.component.project.name" in default Jira template, to fix project name not displaying in Jira ticket summaries for notifications with type NEW_VULNERABLE_DEPENDENCY.

Addressed Issue

Backport change DependencyTrack/hyades#1190

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

sahibamittal and others added 2 commits June 7, 2024 14:27
Co-Authored-By: Niklas <[email protected]>
Co-Authored-By: Lovro Grgurić Mileusnić <[email protected]>
@sahibamittal sahibamittal added v4-port PRs that were ported from the Dependency-Track v4.x code base defect Something isn't working labels Jun 7, 2024
@sahibamittal sahibamittal changed the title Port fix project name in jira Port fix jira and slack notification Jun 7, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.04% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fd1fd6f) 19620 15985 81.47%
Head commit (355028a) 19620 (+0) 15992 (+7) 81.51% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#703) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro
Copy link
Member

nscuro commented Jun 7, 2024

@sahibamittal Could you please also update the templates here: https://github.com/DependencyTrack/hyades/tree/main/notification-publisher/src/test/resources/templates

And update the corresponding publisher tests here: https://github.com/DependencyTrack/hyades/tree/main/notification-publisher/src/test/java/org/dependencytrack/notification/publisher

Sadly the templates will need to be duplicated until DependencyTrack/hyades#932 is done.

@sahibamittal sahibamittal merged commit cd97399 into main Jun 10, 2024
9 checks passed
@sahibamittal sahibamittal deleted the port-fix-project-name-in-jira branch June 10, 2024 12:18
@nscuro nscuro changed the title Port fix jira and slack notification Port: Fix jira and slack notification Jun 12, 2024
@nscuro nscuro added this to the 5.5.0 milestone Jun 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants