Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: Fix for update component external references #697

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Jun 4, 2024

Description

Backport small fix for updating external references of a component.

Addressed Issue

upstream fix : DependencyTrack/dependency-track#3805

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sahibamittal sahibamittal marked this pull request as ready for review June 4, 2024 14:04
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4a0987b) 19568 15947 81.50%
Head commit (7615aaa) 19570 (+2) 15942 (-5) 81.46% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#697) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@nscuro nscuro added this to the 5.5.0 milestone Jun 4, 2024
@nscuro nscuro added defect Something isn't working v4-port PRs that were ported from the Dependency-Track v4.x code base labels Jun 4, 2024
@nscuro nscuro merged commit 4523b24 into main Jun 4, 2024
9 checks passed
@nscuro nscuro deleted the backport-fix-for-update-component-ext-ref branch June 4, 2024 14:51
@nscuro nscuro changed the title Backport fix for update component external references Port: Fix for update component external references Jun 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants