Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include CVSS and OWASP RR vectors in notifications #696

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

VithikaS
Copy link
Collaborator

@VithikaS VithikaS commented Jun 4, 2024

Description

Addressed Issue

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Signed-off-by: vithikashukla <[email protected]>
@nscuro
Copy link
Member

nscuro commented Jun 4, 2024

Thanks @VithikaS!

I think we should include these fields also for the other notifications that include vulnerability information, just to be consistent.

For the same reason, let's also include the OWASP RR vector.

@nscuro nscuro added the enhancement New feature or request label Jun 4, 2024
@nscuro nscuro added this to the 5.5.0 milestone Jun 4, 2024
@VithikaS
Copy link
Collaborator Author

VithikaS commented Jun 4, 2024

Thanks @VithikaS!

I think we should include these fields also for the other notifications that include vulnerability information, just to be consistent.

For the same reason, let's also include the OWASP RR vector.

Added for other Notifications and owasp RR vector string

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+1.40% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b0ffbb1) 18180 14557 80.07%
Head commit (c48de6c) 19576 (+1396) 15948 (+1391) 81.47% (+1.40%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#696) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@nscuro nscuro changed the title Add cvss vector to new vulnerability Notification Include CVSS and OWASP RR vectors in notifications Jun 5, 2024
@nscuro nscuro merged commit 22eaf89 into main Jun 5, 2024
9 checks passed
@nscuro nscuro deleted the add-vector-in-new-vulnerability branch June 5, 2024 09:26
nscuro added a commit to DependencyTrack/hyades that referenced this pull request Jun 6, 2024
nscuro added a commit that referenced this pull request Jun 6, 2024
…PLETE` notifications

This was missed in #696

Signed-off-by: nscuro <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants