Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: ACL: Add projects to team should only show not yet added projects #689

Merged
merged 1 commit into from
May 29, 2024

Conversation

leec94
Copy link
Contributor

@leec94 leec94 commented May 28, 2024

Description

porting issue DependencyTrack/dependency-track#3261 from DT v4.11 to hyades

Addressed Issue

from porting 4.11 issues card here: DependencyTrack/hyades#1190

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Co-authored-by: Ralf King <[email protected]>
Signed-off-by: leec94 <[email protected]>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% (target: -1.00%) 43.75% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (648a7f9) 18050 14447 80.04%
Head commit (1cd50de) 18105 (+55) 14485 (+38) 80.01% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#689) 16 7 43.75%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@nscuro nscuro added enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base labels May 29, 2024
@nscuro nscuro added this to the 5.5.0 milestone May 29, 2024
@nscuro nscuro changed the title porting issue 3261 Port: ACL: Add projects to team should only show not yet added projects May 29, 2024
@nscuro nscuro merged commit 5d64fee into DependencyTrack:main May 29, 2024
8 of 10 checks passed
@leec94 leec94 deleted the port-issue-3261 branch May 29, 2024 13:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants