Address thread safety issues with CelPolicy*RowMappers
#501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instances of the `RowMapper`s are created once by JDBI and then re-used. The current mapper code however assumed an instance to be created per query, thus using a single Protobuf `Builder`, which is not thread-safe. Create a new `Builder` instance for each invocation of `RowMapper#map` instead. Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
nscuro
force-pushed
the
jdbi-rowmapper-threadsafety
branch
from
c5034a2 to
e7e9ff4
Compare
nscuro
changed the title
CelPolicy*RowMappersCelPolicy*RowMappers
mehab
approved these changes
Dec 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instances of the
RowMappers are created once by JDBI and then re-used. The current mapper code however assumed an instance to be created per query, thus using a single ProtobufBuilder, which is not thread-safe.Create a new
Builderinstance for each invocation ofRowMapper#mapinstead.Addressed Issue
N/A
Additional Details
N/A
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly