Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FK violation during BOM processing #422

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Nov 2, 2023

Description

When uploading a BOM to an existing project, components that are no longer current are deleted. When to-be-deleted components had an IntegrityAnalysis associated with them, the deletion was failing due to a foreign key constraint violation.

This is now fixed by ensuring IntegrityAnalysis records are deleted prior to deleting the Component record.

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

When uploading a BOM to an existing project, components that are no longer current are deleted. When to-be-deleted components had an `IntegrityAnalysis` associated with them, the deletion was failing due to a foreign key constraint violation.

This is now fixed by ensuring `IntegrityAnalysis` records are deleted prior to deleting the `Component` record.

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added the defect Something isn't working label Nov 2, 2023
@nscuro nscuro merged commit a127500 into main Nov 2, 2023
@nscuro nscuro deleted the fix-component-delete-during-bomprocessing branch November 2, 2023 12:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants