Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added integrity analysis event on apiserver #339

Merged
merged 13 commits into from
Oct 11, 2023
Merged

added integrity analysis event on apiserver #339

merged 13 commits into from
Oct 11, 2023

Conversation

mehab
Copy link
Collaborator

@mehab mehab commented Oct 2, 2023 •
edited
Loading

Description

Added integrity analysis event on hyades apiserver side for periodic analysis, manual component creation and bom upload events

Addressed Issue

Addresses DependencyTrack/hyades#699

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@mehab mehab requested review from sahibamittal and VithikaS October 2, 2023 13:49
sahibamittal
sahibamittal previously approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@sahibamittal sahibamittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍🏼

@mehab
fixed broken test
76bb0a8 
Signed-off-by: mehab <[email protected]>
@mehab mehab merged commit a32f94c into main Oct 11, 2023
@mehab mehab deleted the feature/addIntegrityCheckNew branch October 11, 2023 17:46
nscuro added a commit that referenced this pull request Oct 19, 2023
@nscuro
Fix NPE during BOM processing when component doesn't have a PURL
02cdef2 
Seems to be a regression introduced in #339

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro mentioned this pull request Oct 19, 2023
Merged
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sahibamittal sahibamittal sahibamittal approved these changes

@VithikaS VithikaS Awaiting requested review from VithikaS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehab @sahibamittal