Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import components that are located under metadata.component.components #278

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

malice00
Copy link
Contributor

Description

Certain SBOM-generators save sub-projects or -modules as part of the component, instead of in the list of dependencies. This change makes sure to also import these as components, so a correct dependency-tree can be generated.

Addressed Issue

Re-implementation of DT PR #2956, which fixes DT Issue #2955

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

…onents'

are imported as well as those under 'components'

Signed-off-by: Roland Asmann <[email protected]>
@nscuro nscuro changed the title Impot componentes that are located under 'metadata.component.components' Import components that are located under metadata.component.components Aug 19, 2023
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @malice00, we'll make sure to give you proper credit when we backport this to the dependency-track repository! 🙌

@nscuro nscuro added the enhancement New feature or request label Aug 19, 2023
@nscuro nscuro merged commit 9d53fc4 into DependencyTrack:main Aug 19, 2023
@malice00
Copy link
Contributor Author

Thanks @malice00, we'll make sure to give you proper credit when we backport this to the dependency-track repository! 🙌

For 2 lines of code? You are to kind! :-)

@nscuro
Copy link
Member

nscuro commented Aug 20, 2023

Contribution is contribution! 😎

mehab pushed a commit that referenced this pull request Sep 12, 2023
…ts` (#278)

are imported as well as those under 'components'

Signed-off-by: Roland Asmann <[email protected]>
Co-authored-by: Roland Asmann <[email protected]>
Signed-off-by: mehab <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components in the SBOM under 'metadata.component.components' are not imported
2 participants