Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude NULLs from component hash indexes #1037

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Exclude NULLs from component hash indexes #1037

merged 1 commit into from
Jan 24, 2025

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Jan 24, 2025

Description

Excludes NULLs from component hash indexes.

Component hashes are only queried via the component search. This implicates that parameters to those queries are never NULL.

We never sort by hashes since that would be pointless.

Chances are extremely high that not all hash types will be populated for any given component.

There is thus no benefit to indexing NULL values. Excluding NULLs will keep indexes sizes smaller, and make index updates faster, while still allowing for performant lookups.

Addressed Issue

Closes DependencyTrack/hyades#1642

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Component hashes are only queried via the component search. This implicates that parameters to those queries are never `NULL`.

We never sort by hashes since that would be pointless.

Chances are extremely high that not all hash types will be populated for any given component.

There is thus no benefit to indexing `NULL` values. Excluding `NULL`s will keep indexes sizes smaller, and make index updates faster, while still allowing for performant lookups.

Closes DependencyTrack/hyades#1642

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added the enhancement New feature or request label Jan 24, 2025
@nscuro nscuro added this to the 5.6.0 milestone Jan 24, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a8a454a) 22285 18477 82.91%
Head commit (e206405) 22285 (+0) 18477 (+0) 82.91% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1037) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@sahibamittal sahibamittal merged commit 7ac0f1f into main Jan 24, 2025
9 checks passed
@sahibamittal sahibamittal deleted the issue-1642 branch January 24, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recreate hash indexes on the COMPONENT table as partial indexes
2 participants