Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible NPEs during tag binding #4594

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Jan 28, 2025

Description

Fixes possible NPEs during tag binding.

Addressed Issue

Fixes #4593

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added the defect Something isn't working label Jan 28, 2025
@nscuro nscuro added this to the 4.12.4 milestone Jan 28, 2025
@nscuro nscuro added the backport/4.12.4 PRs to be backported to version 4.12.4 label Jan 28, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 58.33% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (57b5cc3) 22997 18333 79.72%
Head commit (761f849) 23006 (+9) 18338 (+5) 79.71% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4594) 12 7 58.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit 9bef0c9 into DependencyTrack:master Jan 28, 2025
10 of 11 checks passed
@nscuro nscuro deleted the issue-4593 branch January 28, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/4.12.4 PRs to be backported to version 4.12.4 defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can no longer create project with tags
1 participant