-
-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Repository Bearer Authentication #4483
base: master
Are you sure you want to change the base?
Add Repository Bearer Authentication #4483
Conversation
ea83a6d
to
ff84c04
Compare
@nscure I didn't go the full monty to add another |
b7988b4
to
ab5fc40
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could go even simpler and just instruct users to use the Password field for the bearer token and avoid having to add an extra column and remove the bearerToken field from the PR.
That would be best for now IMO. I don't think having a column for each credential type makes a lot of sense. If we get more variety of credentials (e.g. API keys, certificates, OIDC) we'll need to re-think this anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New columns are added automatically by DataNucleus, a manual migration is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh you're making me feel all nice and warm about DataNucleus all of a sudden.
ab5fc40
to
a0270d5
Compare
Signed-off-by: Valentijn Scholten <[email protected]>
a0270d5
to
00d85df
Compare
@nscuro changed the PR to do just that: send a Bearer token if username is null but password is populated. |
Signed-off-by: Valentijn Scholten <[email protected]>
Signed-off-by: Valentijn Scholten <[email protected]>
Signed-off-by: Valentijn Scholten <[email protected]>
Signed-off-by: Valentijn Scholten <[email protected]>
@AbdelHajou I can see a Could only find documentation on how to authenticate but not what types/styles of authentication are supported: https://learn.microsoft.com/en-us/nuget/consume-packages/consuming-packages-authenticated-feeds I don't think it is valid: https://stackoverflow.com/questions/49580896/http-authentication-without-username EDIT: I have updated the test case to test for |
Signed-off-by: Valentijn Scholten <[email protected]>
Description
Add
Bearer
authentication support for repositories.Addressed Issue
Some repositories require authentication with a Bearer token, for example https://packages.shopware.com and other (private) packagist.com repositories.
Additional Details
FrontEnd PR will be done as soon as API PR is agreed.
Checklist